-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cleanup] Add missing accessibility modifiers in System.Xaml (IDE0040) #10021
base: main
Are you sure you want to change the base?
Conversation
} | ||
private static WriterState state = new Start(); | ||
|
||
private Start() { } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really the standard to put empty constructor/methods in a single line ? From a quick look, this doesn't seem to be the case in WPF, WinForms or Runtime and I couldn't find any documentation about it.
It's probably best to revert these changes to separate them and be able to discuss it separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, that wasn't intentional but it's a setting. Like I've said, I just ran it.
I'll manually revert this later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With that being said though:
Line 315 in 5c87aff
internal RetriesExhaustedException() : base() { } |
wpf/src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Media3D/Transform3DGroup.cs
Line 53 in 5c87aff
public Transform3DGroup() {} |
There's quite a lot! But I'll revert it, not a scope of the PR.
@h3xds1nz |
@dipeshmsft Means I didn't do these by hand, just applied fix per-project. |
Description
Adds missing accessibility modifiers in
System.Xaml
. All of the edits were done automatically.Customer Impact
Cleaner codebase.
Regression
No.
Testing
Local build.
Risk
Minimal.
Microsoft Reviewers: Open in CodeFlow