-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser] Increase timeout and clean up after failed attempts of launching browser when testing #107865
Conversation
It does not help:
|
Can we check if there are other running chrome instances or something to help diagnose the issue? |
If we keep the last commit about killing all other chromes, running WBT locally can be a nuisance. If it works, we should check for running on CI and only then call |
It's not about chrome instances, |
The chrome bump will be ready soon: #107504, maybe that might help? |
Failures are on Windows with
|
The issue is still existing after the Playwright bump, see: https://helix.dot.net/api/2019-06-17/jobs/8d53b01d-113d-4e65-a893-6a5d825a52b6/workitems/Workloads-NoWebcil-ST-Wasm.Build.Tests.TestAppScenarios.LibraryInitializerTests/console. |
Using default chromium from Playwright is broken on Linux:
|
1st and 2nd run with default chrome + higher timeout: success. |
This is a playground for fixing #107771.
The issue is hit only on Windows, where we are running WBT sequentially.
Changes:
linux-x64
dir, not inlinux
. Node requires elevated execution rights, sochmod +x
path was changed accordingly.Browser
and disposing ofPlaywright
.