Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass runningProject to GetUpdateAsync and get projectToRebuild and projectToRestart back #75503

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Pass runningProject to GetUpdateAsync and get projectToRebuild and projectToRestart back #75503

wants to merge 7 commits into from

Conversation

LittleLittleCloud
Copy link

@LittleLittleCloud LittleLittleCloud commented Oct 14, 2024 •
edited
Loading

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 14, 2024
@dotnet-policy-service dotnet-policy-service bot added Community The pull request was submitted by a contributor who is not a Microsoft employee. VSCode labels Oct 14, 2024
tmat
tmat reviewed Oct 15, 2024
View reviewed changes
NuGet.config Outdated Show resolved Hide resolved
tmat
tmat reviewed Oct 15, 2024
View reviewed changes
eng/Directory.Packages.props
@@ -92,7 +92,7 @@
<!--
Subset of Microsoft.VisualStudio.Sdk meta-package (run `csi generate-vssdk-versions.csx` to update based on VSSDK meta-package).
-->
<PackageVersion Include="Microsoft.ServiceHub.Framework" Version="4.5.31" />
<PackageVersion Include="Microsoft.ServiceHub.Framework" Version="4.5.35" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't be updated without updating Microsoft.VisualStudio.SDK. Probably better to bump Microsoft.VisualStudio.SDK in a separate PR.

Copy link
Author

@LittleLittleCloud LittleLittleCloud Oct 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How to determine the right VS SDK version to use. I saw the current version is 17.10.234-preview.1 but that one is not available on nuget.org?

tmat
tmat reviewed Oct 15, 2024
View reviewed changes
src/Features/Core/Portable/EditAndContinue/EmitSolutionUpdateResults.cs
@@ -74,6 +74,127 @@ internal ImmutableArray<ManagedHotReloadDiagnostic> GetAllDiagnostics()

return builder.ToImmutableAndClear();
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this is shown as added. Did you rebase against the latest main?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite follow, what you mean here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the code was copied from https://github.com/dotnet/roslyn/pull/75503/files#diff-95af090e3bc672c6352c9245c5b43e6d1561613fc81afee422e462dc9f17a49fR266.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's true, would be better to find out a way to clean it up

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me look into that

@LittleLittleCloud LittleLittleCloud changed the title [WIP] Pass runningProject to GetUpdateAsync and get projectToRebuild and projectToRestart back Pass runningProject to GetUpdateAsync and get projectToRebuild and projectToRestart back Oct 22, 2024
@LittleLittleCloud LittleLittleCloud marked this pull request as ready for review October 22, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmat tmat tmat left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LittleLittleCloud @tmat