-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Testing] Enabling some UITests from Issues folder in Appium-7 #27181
base: main
Are you sure you want to change the base?
[Testing] Enabling some UITests from Issues folder in Appium-7 #27181
Conversation
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue6945.cs
Outdated
Show resolved
Hide resolved
public void NullPointerExceptionOnFastLabelTextColorChange() | ||
{ | ||
App.WaitForElement("Click me"); | ||
App.Tap("Click me"); | ||
App.WaitForElement("Success"); | ||
App.WaitForElement("Success", timeout: TimeSpan.FromSeconds(3)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, why was not necessary on Xamarin.Forms?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We included a timespan because the sample itself displays the success label after a 2-second delay. In Catalyst, we've encountered random failures without the timespan. To address the flakiness in CI, we incorporated the timespan. We have now verified that the WaitForElementTillPageNavigationSettled extension method works successful in locally across all platforms. We have removed the timespan and committed the changes. Could you please review this and share your thoughts?
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Description of Change
This PR focuses on enabling and updating 7 testcases in Appium. The tests, previously ignored using Fails attribute, are reviewed, and modified to ensure they are functional with the Appium framework.We are going to enable tests in blocks in different PRs. This is the 7th group of tests enabled.
Test Cases: