Fixed Shell Navigating event issue when switching tabs #25749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @Vignesh-SF3580! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
reviewed
Nov 11, 2024
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellItemRenderer.cs
Show resolved
Hide resolved
|
/azp run |
|
/rebase |
github-actions
bot
force-pushed
the
fix-25599
branch
from
f21d409 to
5d88a5f
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
reviewed
Nov 21, 2024
| @@ -0,0 +1,27 @@ | |||
| #if ANDROID // Facing a full exception when clicking on the already selected tab(App.Tap()) in Windows, iOS, and macOS, so excluded those platforms. | |||
There was a problem hiding this comment.
Could you share the exception? Want to determinate if is related with a possible bug on Android or if we need to review something at testing stuff.
There was a problem hiding this comment.
I have revalidated the test cases once more with the latest source and I can confirm that it is now possible to click on the already selected tab using the tab title on Windows and AutomationId on iOS and Mac.
I have modified the test cases to run successfully in all platforms. Could you please review and let me know if you have any concerns?
|
/rebase |
github-actions
bot
force-pushed
the
fix-25599
branch
from
b135e92 to
280f462
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
sheiksyedm
added
the
partner/syncfusion
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Foda
previously approved these changes
Jan 6, 2025
PureWeen
requested changes
Jan 15, 2025
There was a problem hiding this comment.
- Can you split these changes into two PRs?
- I think the implementation on iOS isn't addressing the issue. The problem the user is reporting is that the navigating event isn't firing when they reclick on the Tab. Ideally we don't disable this behavior but we instead route it through the Shell.Navigating features so that users can enable/disable this behavior
Current Behavior:
Behavior After the Fix:
Example Scenario:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Detail
Clicking on an already-selected tab triggered the Navigating event unnecessarily.
Root Cause
The event was triggered without checking if the tab was already selected.
Description of Change
Modified the code to trigger Navigating only if a new tab is selected.
Tested the behaviour in the following platforms
Issues Fixed
Fixes #25599
Screenshots
BeforeFix.mov
AfterFix.mov