Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Imply record label from expressions #17857

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ijklam
Copy link
Contributor

@ijklam ijklam commented Oct 8, 2024

Description

Imply record label from expressions

图片

Part of fsharp/fslang-suggestions#653

Checklist

The feature

  • RFC
  • Test cases added
  • Performance benchmarks added in case of performance changes
  • Release notes entry updated:

Toolset

  • Completion
  • Rename

Copy link
Contributor

github-actions bot commented Oct 8, 2024

❗ Release notes required

@Tangent-90,

Caution

No release notes found for the changed paths (see table below).

Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format.

The following format is recommended for this repository:

* <Informative description>. ([PR #XXXXX](https://github.com/dotnet/fsharp/pull/XXXXX))

See examples in the files, listed in the table below or in th full documentation at https://fsharp.github.io/fsharp-compiler-docs/release-notes/About.html.

If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

You can open this PR in browser to add release notes: open in github.dev

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.200.md No release notes found or release notes format is not correct

@ijklam ijklam changed the title [WIP] Imply anonymous record label from expressions [WIP] Imply record label from expressions Oct 9, 2024
@@ -5562,10 +5562,22 @@ recdExprCore:
None, l
| _ -> raiseParseErrorAt (rhs parseState 2) (FSComp.SR.parsFieldBinding ()) }

/* handles case like { x } */
Copy link
Contributor

@edgarfgp edgarfgp Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also include error recovering recover / ends_coming_soon_or_recover ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will also work with struct {| x |} ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will also work with struct {| x |} ?

yes

@ijklam
Copy link
Contributor Author

ijklam commented Oct 12, 2024

@dotnet-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New
Development

Successfully merging this pull request may close these issues.

2 participants