Publish notes from extensions WG 2024-01-25 #7874
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredpar
reviewed
Jan 26, 2024
| This allows for a method group with both methods from extension and underlying type. | ||
|
|
||
| ``` | ||
| var a1 = EDerived.M2; // method group should incorporate members of EDerived, EBase and C |
There was a problem hiding this comment.
EBase.M2 is private
EDerived has a Method (also private) but not M2
Based on the comment I expected to see M2 from a few types but only see one that would be applicable here. Not sure how Method factors into this.
|
|
||
| ### Downlevel support | ||
| The new proposed lowering strategy (using `Unsafe.As`) doesn't benefit from using a `ref struct`. | ||
| Using a `ref struct` prohibits any downlevel support. |
There was a problem hiding this comment.
Why? I mean I'm glad that struct can be used but unclear what ref struct was stopping in terms of downlevel support.
| We instead want to treat the underlying type as a base type. It still comes into play last (meaning after all base extensions) but not conditionally. | ||
| This allows for a method group with both methods from extension and underlying type. | ||
|
|
||
| ``` |
There was a problem hiding this comment.
Suggested change
| ``` | |
| ```csharp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI @MadsTorgersen @AlekseyTs @333fred
Relates to test plan dotnet/roslyn#66722