-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Showing
3,212 changed files
with
48,616 additions
and
57,661 deletions.
The diff you're trying to view is too large. We only load the first 3000 changed files.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| # Code of Conduct | ||
|
|
||
| This project uses the [.NET Foundation Code of Conduct](https://dotnetfoundation.org/code-of-conduct) to define expected conduct in our community. | ||
| Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by contacting a project maintainer at [email protected]. | ||
| Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by contacting a project maintainer at <[email protected]>. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,13 +4,15 @@ The .NET maintainer team aims to support a productive and safe working environme | |
|
|
||
| The following two lists summarize how maintainers will act. A more detailed description follows this summary. | ||
|
|
||
| **Maintainers will** | ||
| Maintainers will: | ||
|
|
||
| - Encourage your contributions and participation and provide clear and direct feedback, including when your contributions are not accepted. | ||
| - Close issues and PRs as a means of making repos more efficient to use for everyone. They can be re-opened, as needed. | ||
| - Edit comments for formatting [if and only if (iff)](https://en.wikipedia.org/wiki/If_and_only_if) the edit adds substantially to the readability or usability of the comment. No changes will be made to spelling, wording, meaning, or emphasis. | ||
| - Report abusive behavior to the [Code of Conduct review group](mailto:[email protected]). | ||
|
|
||
| **Maintainers won't** | ||
| Maintainers won't: | ||
|
|
||
| - Edit contributor comments as a general rule. GitHub provides [edit history](https://blog.github.com/changelog/2018-05-24-comment-edit-history/) which makes editing more acceptable as there is a way to see an audit log. However, contributors might still be surprised when they see statements or phrases under their name that they don't recall making. Transparency is a cornerstone of effective discourse and its absence undermines trust. And a change log doesn't fully eliminate these concerns. | ||
|
|
||
| ## Respect your Contributions | ||
|
|
@@ -27,7 +29,7 @@ Maintainers will take actions to make repo engagement more efficient for everyon | |
|
|
||
| Maintainers may edit PR and issue titles to improve readability and/or accuracy. GitHub provides history for title changes. | ||
|
|
||
| Maintainers may edit your comments if and only if the edit adds substantially to the readability or usability of the comment and doesn't change the content. The maintainer will add a short descriptive note with their @handle to explain their change at the end of your comment (for example: "_Edited by @richlander -- added call-stack formatting_"). | ||
| Maintainers may edit your comments if and only if the edit adds substantially to the readability or usability of the comment and doesn't change the content. The maintainer will add a short descriptive note with their @handle to explain their change at the end of your comment (for example: "_Edited by @richlander -- added call-stack formatting_"). | ||
|
|
||
| Maintainers may make the following changes to contributor comments: | ||
|
|
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,3 @@ | ||
| This document has moved to https://github.com/dotnet/designs/blob/main/accepted/2020/diagnostics/portable-pdb.md | ||
| # File has moved | ||
|
|
||
| This document has moved to <https://github.com/dotnet/designs/blob/main/accepted/2020/diagnostics/portable-pdb.md> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,3 @@ | ||
| This document has moved to https://github.com/dotnet/designs/blob/main/accepted/2020/diagnostics/source-link.md | ||
| # File has moved | ||
|
|
||
| This document has moved to <https://github.com/dotnet/designs/blob/main/accepted/2020/diagnostics/source-link.md> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,15 +2,12 @@ | |
|
|
||
| It looks like you probably hit a bug in .NET Native. | ||
| You can help make .NET better by sending a bug report. | ||
| However, take a look at the [Known Issues](#known-issues) section below | ||
| before sending a bug report. There may already be a | ||
| workaround for your issue. | ||
|
|
||
| ## Creating and Sending a .NET Native repro | ||
|
|
||
| 1. Add `<NetNativeReproPath>C:\myReproDirectory</NetNativeReproPath>` to the primary PropertyGroup in your project file, the file ending in csproj, vsproj, vcxproj, or jsproj. You can set `C:\myReproDirectory` to any directory that exists. [Examples are below.](#examples) | ||
| 2. Rebuild your app. You will find ilcRepro.zip in the repro directory you specified above. | ||
| 3. Put ilcRepro.zip on your OneDrive, Dropbox, or another storage provider. Send a link to ilcRepro.zip and a description of your issue to [email protected]. | ||
| 3. Put ilcRepro.zip on your OneDrive, Dropbox, or another storage provider. Send a link to ilcRepro.zip and a description of your issue to <[email protected]>. | ||
| 4. Remove `<NetNativeReproPath>` from your project file. | ||
|
|
||
| ## Compilation Failure in Store | ||
|
|
@@ -19,102 +16,110 @@ UWP apps containing managed code are compiled in Store using the .NET Native Too | |
|
|
||
| `This submission failed due to compilation error {0}. More information about this error can be found here.` | ||
|
|
||
| In such a case, please ensure that you were able to build your application in Release mode successfully at the time you submitted it to Store. If it did, please send the error number you got in the message above and email [email protected]. | ||
| In such a case, please ensure that you were able to build your application in Release mode successfully at the time you submitted it to Store. If it did, please send the error number you got in the message above and email <[email protected]>. | ||
|
|
||
| For help with any other issues, please share their details at https://connect.microsoft.com/visualstudio/ | ||
| For help with any other issues, please share their details at <https://connect.microsoft.com/visualstudio/> | ||
|
|
||
| ## Examples | ||
|
|
||
| Below are examples of where to add the `<NetNativeReproPath>` tag. | ||
|
|
||
| ### C# (*.csproj) | ||
|
|
||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
| <Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" /> | ||
| <PropertyGroup> | ||
| <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration> | ||
| <Platform Condition=" '$(Platform)' == '' ">x86</Platform> | ||
| <ProjectGuid>{B44664F5-278C-4ABE-B62E-A5CA20E3DC48}</ProjectGuid> | ||
| <OutputType>AppContainerExe</OutputType> | ||
| <AppDesignerFolder>Properties</AppDesignerFolder> | ||
| <RootNamespace>App1</RootNamespace> | ||
| <AssemblyName>App1</AssemblyName> | ||
| <DefaultLanguage>en-US</DefaultLanguage> | ||
| <TargetPlatformIdentifier>UAP</TargetPlatformIdentifier> | ||
| <TargetPlatformVersion>10.0.10158.0</TargetPlatformVersion> | ||
| <TargetPlatformMinVersion>10.0.10158.0</TargetPlatformMinVersion> | ||
| <MinimumVisualStudioVersion>14</MinimumVisualStudioVersion> | ||
| <EnableDotNetNativeCompatibleProfile>true</EnableDotNetNativeCompatibleProfile> | ||
| <FileAlignment>512</FileAlignment> | ||
| <ProjectTypeGuids>{A5A43C5B-DE2A-4C0C-9213-0A381AF9435A};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}</ProjectTypeGuids> | ||
| <PackageCertificateKeyFile>App1_TemporaryKey.pfx</PackageCertificateKeyFile> | ||
| <NetNativeReproPath>C:\myRepro</NetNativeReproPath> | ||
| </PropertyGroup> | ||
| ⋮ | ||
| </Project> | ||
| ```xml | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
| <Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" /> | ||
| <PropertyGroup> | ||
| <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration> | ||
| <Platform Condition=" '$(Platform)' == '' ">x86</Platform> | ||
| <ProjectGuid>{B44664F5-278C-4ABE-B62E-A5CA20E3DC48}</ProjectGuid> | ||
| <OutputType>AppContainerExe</OutputType> | ||
| <AppDesignerFolder>Properties</AppDesignerFolder> | ||
| <RootNamespace>App1</RootNamespace> | ||
| <AssemblyName>App1</AssemblyName> | ||
| <DefaultLanguage>en-US</DefaultLanguage> | ||
| <TargetPlatformIdentifier>UAP</TargetPlatformIdentifier> | ||
| <TargetPlatformVersion>10.0.10158.0</TargetPlatformVersion> | ||
| <TargetPlatformMinVersion>10.0.10158.0</TargetPlatformMinVersion> | ||
| <MinimumVisualStudioVersion>14</MinimumVisualStudioVersion> | ||
| <EnableDotNetNativeCompatibleProfile>true</EnableDotNetNativeCompatibleProfile> | ||
| <FileAlignment>512</FileAlignment> | ||
| <ProjectTypeGuids>{A5A43C5B-DE2A-4C0C-9213-0A381AF9435A};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}</ProjectTypeGuids> | ||
| <PackageCertificateKeyFile>App1_TemporaryKey.pfx</PackageCertificateKeyFile> | ||
| <NetNativeReproPath>C:\myRepro</NetNativeReproPath> | ||
| </PropertyGroup> | ||
| ⋮ | ||
| </Project> | ||
| ``` | ||
|
|
||
| ### VB (*.vbproj) | ||
|
|
||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
| <Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" /> | ||
| <PropertyGroup> | ||
| <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration> | ||
| <Platform Condition=" '$(Platform)' == '' ">x86</Platform> | ||
| <ProjectGuid>{8C7ADA9E-47DF-4937-A1D9-62CA9B88A100}</ProjectGuid> | ||
| <OutputType>AppContainerExe</OutputType> | ||
| <RootNamespace>App4</RootNamespace> | ||
| <AssemblyName>App4</AssemblyName> | ||
| <DefaultLanguage>en-US</DefaultLanguage> | ||
| <TargetPlatformIdentifier>UAP</TargetPlatformIdentifier> | ||
| <TargetPlatformVersion>10.0.10158.0</TargetPlatformVersion> | ||
| <TargetPlatformMinVersion>10.0.10158.0</TargetPlatformMinVersion> | ||
| <MinimumVisualStudioVersion>14</MinimumVisualStudioVersion> | ||
| <EnableDotNetNativeCompatibleProfile>true</EnableDotNetNativeCompatibleProfile> | ||
| <FileAlignment>512</FileAlignment> | ||
| <ProjectTypeGuids>{A5A43C5B-DE2A-4C0C-9213-0A381AF9435A};{F184B08F-C81C-45F6-A57F-5ABD9991F28F}</ProjectTypeGuids> | ||
| <PackageCertificateKeyFile>App4_TemporaryKey.pfx</PackageCertificateKeyFile> | ||
| <NetNativeReproPath>C:\myRepro</NetNativeReproPath> | ||
| </PropertyGroup> | ||
| ⋮ | ||
| </Project> | ||
| ```xml | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
| <Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" /> | ||
| <PropertyGroup> | ||
| <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration> | ||
| <Platform Condition=" '$(Platform)' == '' ">x86</Platform> | ||
| <ProjectGuid>{8C7ADA9E-47DF-4937-A1D9-62CA9B88A100}</ProjectGuid> | ||
| <OutputType>AppContainerExe</OutputType> | ||
| <RootNamespace>App4</RootNamespace> | ||
| <AssemblyName>App4</AssemblyName> | ||
| <DefaultLanguage>en-US</DefaultLanguage> | ||
| <TargetPlatformIdentifier>UAP</TargetPlatformIdentifier> | ||
| <TargetPlatformVersion>10.0.10158.0</TargetPlatformVersion> | ||
| <TargetPlatformMinVersion>10.0.10158.0</TargetPlatformMinVersion> | ||
| <MinimumVisualStudioVersion>14</MinimumVisualStudioVersion> | ||
| <EnableDotNetNativeCompatibleProfile>true</EnableDotNetNativeCompatibleProfile> | ||
| <FileAlignment>512</FileAlignment> | ||
| <ProjectTypeGuids>{A5A43C5B-DE2A-4C0C-9213-0A381AF9435A};{F184B08F-C81C-45F6-A57F-5ABD9991F28F}</ProjectTypeGuids> | ||
| <PackageCertificateKeyFile>App4_TemporaryKey.pfx</PackageCertificateKeyFile> | ||
| <NetNativeReproPath>C:\myRepro</NetNativeReproPath> | ||
| </PropertyGroup> | ||
| ⋮ | ||
| </Project> | ||
| ``` | ||
|
|
||
| ### C++ (*.vcxproj) | ||
|
|
||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
| <PropertyGroup Label="Globals"> | ||
| <ProjectGuid>{74010e92-8ead-4acc-8fc6-7db385af579b}</ProjectGuid> | ||
| <RootNamespace>App2</RootNamespace> | ||
| <DefaultLanguage>en-US</DefaultLanguage> | ||
| <MinimumVisualStudioVersion>14.0</MinimumVisualStudioVersion> | ||
| <AppContainerApplication>true</AppContainerApplication> | ||
| <ApplicationType>Windows Store</ApplicationType> | ||
| <WindowsTargetPlatformVersion>10.0.10158.0</WindowsTargetPlatformVersion> | ||
| <WindowsTargetPlatformMinVersion>10.0.10158.0</WindowsTargetPlatformMinVersion> | ||
| <ApplicationTypeRevision>10.0</ApplicationTypeRevision> | ||
| <EnableDotNetNativeCompatibleProfile>true</EnableDotNetNativeCompatibleProfile> | ||
| <NetNativeReproPath>C:\myRepro</NetNativeReproPath> | ||
| </PropertyGroup> | ||
| ⋮ | ||
| </Project> | ||
| ```xml | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
| <PropertyGroup Label="Globals"> | ||
| <ProjectGuid>{74010e92-8ead-4acc-8fc6-7db385af579b}</ProjectGuid> | ||
| <RootNamespace>App2</RootNamespace> | ||
| <DefaultLanguage>en-US</DefaultLanguage> | ||
| <MinimumVisualStudioVersion>14.0</MinimumVisualStudioVersion> | ||
| <AppContainerApplication>true</AppContainerApplication> | ||
| <ApplicationType>Windows Store</ApplicationType> | ||
| <WindowsTargetPlatformVersion>10.0.10158.0</WindowsTargetPlatformVersion> | ||
| <WindowsTargetPlatformMinVersion>10.0.10158.0</WindowsTargetPlatformMinVersion> | ||
| <ApplicationTypeRevision>10.0</ApplicationTypeRevision> | ||
| <EnableDotNetNativeCompatibleProfile>true</EnableDotNetNativeCompatibleProfile> | ||
| <NetNativeReproPath>C:\myRepro</NetNativeReproPath> | ||
| </PropertyGroup> | ||
| ⋮ | ||
| </Project> | ||
| ``` | ||
|
|
||
| ### JS (*.jsproj) | ||
|
|
||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
| ⋮ | ||
| <PropertyGroup> | ||
| <EnableDotNetNativeCompatibleProfile>true</EnableDotNetNativeCompatibleProfile> | ||
| <TargetPlatformIdentifier>UAP</TargetPlatformIdentifier> | ||
| <TargetPlatformVersion>10.0.10158.0</TargetPlatformVersion> | ||
| <TargetPlatformMinVersion>10.0.10158.0</TargetPlatformMinVersion> | ||
| <MinimumVisualStudioVersion>$(VersionNumberMajor).$(VersionNumberMinor)</MinimumVisualStudioVersion> | ||
| <DefaultLanguage>en-US</DefaultLanguage> | ||
| <PackageCertificateKeyFile>App3_TemporaryKey.pfx</PackageCertificateKeyFile> | ||
| <NetNativeReproPath>C:\myRepro</NetNativeReproPath> | ||
| </PropertyGroup> | ||
| ⋮ | ||
| </Project> | ||
| ```xml | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
| ⋮ | ||
| <PropertyGroup> | ||
| <EnableDotNetNativeCompatibleProfile>true</EnableDotNetNativeCompatibleProfile> | ||
| <TargetPlatformIdentifier>UAP</TargetPlatformIdentifier> | ||
| <TargetPlatformVersion>10.0.10158.0</TargetPlatformVersion> | ||
| <TargetPlatformMinVersion>10.0.10158.0</TargetPlatformMinVersion> | ||
| <MinimumVisualStudioVersion>$(VersionNumberMajor).$(VersionNumberMinor)</MinimumVisualStudioVersion> | ||
| <DefaultLanguage>en-US</DefaultLanguage> | ||
|
|
||
| <PackageCertificateKeyFile>App3_TemporaryKey.pfx</PackageCertificateKeyFile> | ||
| <NetNativeReproPath>C:\myRepro</NetNativeReproPath> | ||
| </PropertyGroup> | ||
| ⋮ | ||
| </Project> | ||
| ``` | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.