Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align TdsExecuteRPC between netcore and netfx #2985

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MichelZ
Copy link
Contributor

@MichelZ MichelZ commented Nov 7, 2024

Splitting up TdsExecuteRPC to multiple functions to align netcore and netfx

Part of #2953

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 81.59204% with 37 lines in your changes missing coverage. Please review.

Project coverage is 72.46%. Comparing base (4bc9ee6) to head (ed8552b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs 81.40% 37 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2985      +/-   ##
==========================================
- Coverage   72.50%   72.46%   -0.04%     
==========================================
  Files         288      288              
  Lines       59529    59548      +19     
==========================================
- Hits        43159    43150       -9     
- Misses      16370    16398      +28     
Flag Coverage Δ
addons 92.58% <ø> (ø)
netcore 75.37% <100.00%> (-0.07%) ⬇️
netfx 70.93% <81.40%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant