-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align ADP.IsEmpty -> string.IsNullOrEmpty #2961
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this method exists, I have no idea. I will look forward to removing it soon enough.
@cheenamalhotra Could you also run this pipeline? Thx :) |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@benrr101 IsNullOrEmpty did not exist in .NET Framework 1 😅 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2961 +/- ##
==========================================
+ Coverage 72.31% 72.34% +0.02%
==========================================
Files 288 288
Lines 59660 59660
==========================================
+ Hits 43145 43162 +17
+ Misses 16515 16498 -17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This PR simply changes ADP.IsEmpty to string.IsNullOrEmpty to align netfx with netcore
Part of #2953