Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align ADP.IsEmpty -> string.IsNullOrEmpty #2961

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

MichelZ
Copy link
Contributor

@MichelZ MichelZ commented Nov 2, 2024

This PR simply changes ADP.IsEmpty to string.IsNullOrEmpty to align netfx with netcore

Part of #2953

Copy link
Contributor

@benrr101 benrr101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this method exists, I have no idea. I will look forward to removing it soon enough.

@benrr101 benrr101 added the Common Project 🚮 Things that relate to the common project project label Nov 4, 2024
@MichelZ
Copy link
Contributor Author

MichelZ commented Nov 5, 2024

@cheenamalhotra Could you also run this pipeline? Thx :)

@cheenamalhotra
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ErikEJ
Copy link
Contributor

ErikEJ commented Nov 5, 2024

@benrr101 IsNullOrEmpty did not exist in .NET Framework 1 😅

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.34%. Comparing base (9d5ca32) to head (b20df43).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2961      +/-   ##
==========================================
+ Coverage   72.31%   72.34%   +0.02%     
==========================================
  Files         288      288              
  Lines       59660    59660              
==========================================
+ Hits        43145    43162      +17     
+ Misses      16515    16498      -17     
Flag Coverage Δ
addons 92.58% <ø> (ø)
netcore 75.39% <ø> (-0.04%) ⬇️
netfx 70.76% <71.42%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benrr101 benrr101 merged commit 7214342 into dotnet:main Nov 5, 2024
76 checks passed
@benrr101 benrr101 added this to the 6.0-preview3 milestone Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Common Project 🚮 Things that relate to the common project project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants