Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align keyword ordering and operation ordering netfx/netcore #2958

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

MichelZ
Copy link
Contributor

@MichelZ MichelZ commented Nov 2, 2024

This one deals with keyword ordering and operation ordering, as well as adding some missing keywords.
No code logic has changed, so should be straight forward to review I hope

Part of #2953

@benrr101 benrr101 added the Common Project 🚮 Things that relate to the common project project label Nov 4, 2024
@cheenamalhotra
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.58%. Comparing base (9d5ca32) to head (15ecbf5).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2958       +/-   ##
===========================================
+ Coverage   72.31%   92.58%   +20.26%     
===========================================
  Files         288        6      -282     
  Lines       59660      310    -59350     
===========================================
- Hits        43145      287    -42858     
+ Misses      16515       23    -16492     
Flag Coverage Δ
addons 92.58% <ø> (ø)
netcore ?
netfx ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benrr101 benrr101 merged commit 365d417 into dotnet:main Nov 5, 2024
76 checks passed
@benrr101 benrr101 added this to the 6.0-preview3 milestone Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Common Project 🚮 Things that relate to the common project project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants