Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

converted the post_comment view to a class based view building on top of the generic FormView #170

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

converted the post_comment view to a class based view building on top of the generic FormView #170

wants to merge 4 commits into from

Commits on Jul 12, 2021

  1. rebuild the comment post view using the generic FormView class 

    We tried to strictly follow the logic of the original code and keep as much of it as possible while just migrating the code into the structure of the generic FormView.
    @thomst
    thomst committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    6fcedcf View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2021

  1. made the use of the BadRequest exception more straight foreward 

    Instead of passing the CommentPostBadRequest  object we just initialize it within the BadRequest itself.
    @thomst
    thomst committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    eb9ca70 View commit details
    Browse the repository at this point in the history

  2. use the TemplateResponseMixin logic for rendering a the comment form

    @thomst
    thomst committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    9ca91bb View commit details
    Browse the repository at this point in the history

  3. just smooth the code a bit

    @thomst
    thomst committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    dd5724d View commit details
    Browse the repository at this point in the history