fix: add analytics to plus #3817
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omBratteng
requested review from
rebelchris,
ilasw,
capJavert,
sshanzel,
nensidosari and
AmarTrebinjac
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
omBratteng
force-pushed
the
AS-712-analytics
branch
from
f6102eb
to
5d5cf7b
Compare
omBratteng
commented
Nov 15, 2024
Comment on lines
+77
to
+87
| // This doesn't exist in the original code | ||
| case 'checkout.warning' as CheckoutEventNames: | ||
| logSubscriptionEvent({ | ||
| event_name: LogEvent.WarningCheckout, | ||
| }); | ||
| break; | ||
| case CheckoutEventNames.CHECKOUT_ERROR: | ||
| logSubscriptionEvent({ | ||
| event_name: LogEvent.ErrorCheckout, | ||
| }); | ||
| break; |
There was a problem hiding this comment.
Waiting for some clarification on these, as they don't contain anything from the taxonomy
rebelchris
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
AS-712
Preview domain
https://as-712-analytics.preview.app.daily.dev