feat: updates in Projects, TMs, Files, Screenshots, Strings APIs #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
==========================================
+ Coverage 98.08% 98.11% +0.03%
==========================================
Files 61 61
Lines 2810 2899 +89
==========================================
+ Hits 2756 2844 +88
- Misses 54 55 +1 ☔ View full report in Codecov by Sentry. |
…I Resources updates and refactoring. Some other small style changes.
keshandrr
force-pushed
the
client-updates
branch
from
8f34404
to
d32d068
Compare
Comment on lines
+32
to
+54
| # Offense count: 14 | ||
| # This cop supports safe autocorrection (--autocorrect). | ||
| # Configuration parameters: EnforcedStyle. | ||
| # SupportedStyles: empty_lines, no_empty_lines | ||
| Layout/EmptyLinesAroundBlockBody: | ||
| Exclude: | ||
| - 'spec/api_resources/labels_spec.rb' | ||
| - 'spec/api_resources/projects_spec.rb' | ||
| - 'spec/api_resources/source_files_spec.rb' | ||
| - 'spec/api_resources/source_strings_spec.rb' | ||
| - 'spec/api_resources/translation_memory_spec.rb' | ||
|
|
||
| # Offense count: 10 | ||
| # This cop supports safe autocorrection (--autocorrect). | ||
| # Configuration parameters: EnforcedStyle. | ||
| # SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines | ||
| Layout/EmptyLinesAroundModuleBody: | ||
| Exclude: | ||
| - 'lib/crowdin-api/api_resources/labels.rb' | ||
| - 'lib/crowdin-api/api_resources/projects.rb' | ||
| - 'lib/crowdin-api/api_resources/source_files.rb' | ||
| - 'lib/crowdin-api/api_resources/source_strings.rb' | ||
| - 'lib/crowdin-api/api_resources/translation_memory.rb' |
There was a problem hiding this comment.
It looks wrong to exclude linter warnings for the specified files
| @@ -127,10 +128,10 @@ def check_tm_import_status(tm_id = nil, import_id = nil) | |||
| Web::SendRequest.new(request).perform | |||
| end | |||
|
|
|||
| def search_tms_concordance(project_id = nil, query = {}) | |||
| def search_tms_concordance(query = {}, project_id = nil) | |||
There was a problem hiding this comment.
Why is the order changed? It might break compatibility
andrii-bodnar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will close the following issues:
qaChecksIgnorableCategoriessupport #42