Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run_loop::schedule() should not have set_stopped_t() in its completion signatures if passed an env with an unstoppable_token #294

Open
lewissbaker opened this issue Oct 16, 2024 · 0 comments

Comments

@lewissbaker
Copy link
Collaborator

[exec.run.loop.types] p5 specifies that the completion-signatures of the run-loop-sender are always:

  completion_signatures<set_value_t(), set_error_t(exception_ptr), set_stopped_t()>

However, if the environment of the receiver connected to this sender has an unstoppable stop-token then it will never call set_stopped_t. We should conditionally add the set_stopped_t completion-signature only if the environment has a stop-token where a stop is possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant