Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use m2w64-sysroot as m2w64_c_stdlib; set version #6678

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

h-vetinari
Copy link
Member

This is I think a leftover TODO from the work that @isuruf did on the m2w64-stack. I notice that other places (e.g. r-base or our linux compilers) set

c_stdlib:                  # [win]
  - m2w64-sysroot          # [win]
c_stdlib_version:          # [win]
  - 12                     # [win]

AFAICT this would be the correct behaviour to aim for for recipes that use {{ stdlib("m2w64_c") }} # [win]. I noticed this in libhwloc, where the default rerender still pulls in an old toolchain.

@h-vetinari h-vetinari requested a review from a team as a code owner November 10, 2024 04:44
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@isuruf
Copy link
Member

isuruf commented Nov 10, 2024

There's a migrator on the way, so let's not do this until we are ready to merge in the migrator

@h-vetinari
Copy link
Member Author

There's a migrator on the way, so let's not do this until we are ready to merge in the migrator

Is there any issue or PR for this? If not, could you please open one? It's hard to keep track of things if it's all just in our heads.

@isuruf
Copy link
Member

isuruf commented Nov 11, 2024

No there's no issue. We usually don't make issue for migrators to be closed. Please open an issue if you prefer.

@isuruf isuruf marked this pull request as draft November 11, 2024 22:20
@h-vetinari
Copy link
Member Author

Ah I misunderstood. When you said "on the way" I thought you meant a new one, but presumably you mean the R migration?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants