Browser theme based init #77
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hossain-khan
added a commit
to hossain-khan/hossainkhan.com
that referenced
this pull request
Dec 13, 2024
Change taken from coliff/dark-mode-switch#77 Related issues: * coliff/dark-mode-switch#26 * coliff/dark-mode-switch#38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user don't selected a preferred theme with the switch, the browser theme will used if available.
Description
It now save in local storage "light" or "dark", if nothing is saved, it use browser theme on init
Motivation and Context
This is only a feature request to make this better for the possibilities of the web api
How Has This Been Tested?
Manual test on:
Screenshots (if appropriate):
Types of changes
Checklist:
npm run testand test passes