Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin-typescript): setup plugin project base #917

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

BioPhoton
Copy link
Collaborator

This PR include the foundation for the TypeScript plugin.

It includes Nx related files, testing and typescript setup.

@BioPhoton BioPhoton marked this pull request as ready for review January 10, 2025 20:11
Copy link

github-actions bot commented Jan 10, 2025

Code PushUp

😟 Code PushUp report has regressed – compared target commit 62cbc04 with source commit 1686dda.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 53 🟡 50 ↓ −2.7
Code coverage 🟢 91 🟢 91 ↓ −0.1
Documentation 🔴 23 🔴 23 ↓ −0.1
Security 🟡 81 🟡 81
Updates 🟡 77 🟡 77
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👎 3 groups regressed, 👎 7 audits regressed, 11 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 53 🟡 50 ↓ −2.7
Code coverage Code coverage metrics 🟢 91 🟢 91 ↓ −0.1
JSDoc coverage Documentation coverage 🔴 23 🔴 23 ↓ −0.1

15 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse First Contentful Paint 🟨 2.8 s 🟥 3.1 s ↑ +9.5 %
Lighthouse Speed Index 🟥 6.0 s 🟥 6.3 s ↑ +6.3 %
Lighthouse Largest Contentful Paint 🟨 3.2 s 🟨 3.4 s ↑ +5.9 %
Lighthouse Time to Interactive 🟥 14.3 s 🟥 16.7 s ↑ +16.5 %
Code coverage Branch coverage 🟨 86 % 🟨 85.9 % ↓ −0.1 %
JSDoc coverage Variables coverage 🟥 193 undocumented variables 🟥 194 undocumented variables ↑ +0.5 %
Code coverage Line coverage 🟩 90.6 % 🟩 90.6 % ↓ −0.1 %
Lighthouse Minimizes main-thread work 🟥 14.3 s 🟥 19.7 s ↑ +37.7 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,814 KiB 🟩 Total size was 1,810 KiB ↓ −0.2 %
Lighthouse JavaScript execution time 🟥 6.9 s 🟥 9.9 s ↑ +43.5 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +16.5 %
Lighthouse Total Blocking Time 🟥 4,560 ms 🟥 6,450 ms ↑ +41.4 %
Lighthouse Max Potential First Input Delay 🟥 2,440 ms 🟥 3,050 ms ↑ +25.3 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 1,000 ms 🟥 Potential savings of 1,200 ms ↑ +19.9 %
Lighthouse Initial server response time was short 🟩 Root document took 280 ms 🟩 Root document took 450 ms ↑ +63.2 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↑ +0.1 %
Lighthouse Network Round Trip Times 🟩 60 ms 🟩 20 ms ↓ −64.8 %
Lighthouse Server Backend Latencies 🟩 90 ms 🟩 120 ms ↑ +29 %

578 other audits are unchanged.

packages/plugin-typescript/package.json Outdated Show resolved Hide resolved
export default tseslint.config(
...baseConfig,
{
files: ['**/*.ts', '!**/mocks'],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other projects don't have mocks directory excluded this way. Is it needed? The **/mocks/fixtures pattern is globally ignored, BTW.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants