Proper mobile view of About page. #302
Conversation
|
@hemangsk please review this pr |
There was a problem hiding this comment.
@AkshJain99 It is not a good idea to change the vendor files since these are from a third party and used across the project. Custom CSS goes here https://github.com/coala/coalaCSS
|
@bharatpurohit97 really but in coala css i think there isno such thing which let me to fix this issue |
|
and also @bharatpurohit97 changes done in coalaCSS is not reflected in coala frontend then how can we change there without observing those changes locally |
|
I too agree, if it's a vendor CSS file, do not modify it. Instead, change the element class in the HTML file and override the style in custom CSS. |
|
@frextrite but i wanna to ask that how the changes done in coalacss will reflect in coala frontend when run locally |
|
@frextrite I am not getting if i cant change vendor file then what is the otherway through which i can change the style? becoz changes done in coalacss will not reflect in frontend |
Travis tests have failedHey @AkshJain99, 1st Builddocker run -v=$(pwd):/app --workdir=/app coala/base coala --ciTravisBuddy Request Identifier: 9788f440-180c-11e9-982a-45f784180d69 |
partials/tabs/about.html
Outdated
| @@ -129,3 +129,4 @@ <h2 class="fine center">about</h2> | |||
| $('ul.tabs').tabs(); | |||
| }); | |||
| </script> | |||
| <link rel="stylesheet" href="/resources/css/people.css"> | |||
There was a problem hiding this comment.
Line contains following spacing inconsistencies:
- No newline at EOF.
Origin: SpaceConsistencyBear, Section: spacing.
The issue can be fixed by applying the following patch:
--- a/tmp/tmph_inr9rr/partials/tabs/about.html
+++ b/tmp/tmph_inr9rr/partials/tabs/about.html
@@ -129,4 +129,4 @@
$('ul.tabs').tabs();
});
</script>
-<link rel="stylesheet" href="/resources/css/people.css">+<link rel="stylesheet" href="/resources/css/people.css">
|
What problem u r getting @utkarsh2102 ?
|
Mobile view of about page looks fine now by adding scrolling feature. Fixes coala#298
Travis tests have failedHey @AkshJain99, 1st Builddocker run -v=$(pwd):/app --workdir=/app coala/base coala --ciTravisBuddy Request Identifier: 2d687e40-1894-11e9-8383-81bede5545a8 |
but @KVGarg yes i know that but where did i changed materialise css? i did that earlier but i think now its perfect |
|
|
Mobile view of about page
looks fine now by adding
scrolling feature.
Fixes #298
For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Checklist
them.
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!
After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.
Please consider helping us by reviewing other peoples pull requests as well:
cobot mark wip <URL>to get it outof the review queue.
The more you review, the more your score will grow at coala.io and we will
review your PRs faster!