.travis.yml: Check GITHUB_TOKEN before deploy #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to check this again by pushing to my master. |
|
It works correctly on master, but needs a nice error message |
jayvdb
force-pushed
the
check-deploy-token
branch
from
410adc9
to
2a3fda4
Compare
Provide a helpful error message early in build when pushing to master without deploy variable GITHUB_TOKEN. Closes coala#60
andrewda
reviewed
Jun 13, 2018
|
|
||
| set -ex | ||
|
|
||
| if [[ $TRAVIS_BRANCH == master && $TRAVIS_EVENT_TYPE == push && |
There was a problem hiding this comment.
"$TRAVIS_BRANCH" == "master" && "$TRAVIS_EVENT_TYPE" == "push" is the convention, I believe, so that words with spaces or special characters don't break the script.
andrewda
reviewed
Jun 13, 2018
| if [[ $TRAVIS_BRANCH == master && $TRAVIS_EVENT_TYPE == push && | ||
| ! "$GITHUB_TOKEN" ]]; then | ||
| echo "Please set GITHUB_TOKEN in your Travis CI environment settings" | ||
| false |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #60