CI Fixes

[Azanul]

Fixes #156

[netlify]

✅ Deploy Preview for tag-env-sustainability canceled.

Name	Link
🔨 Latest commit	299e858
🔍 Latest deploy log	https://app.netlify.com/sites/tag-env-sustainability/deploys/64cea94321bd22000780295a

[chalin]

Hi @Azanul - thanks for this, but because reactivating checks also implies the need to fix the reported issues (otherwise PR checks will fail), I've decided to tackle #156 step-wise by reactivating each check separately (and fixing the reported issues at the same time). For example, see #169. /cc @cjyabraham

[Azanul]

Hi @Azanul - thanks for this, but because reactivating checks also implies the need to fix the reported issues (otherwise PR checks will fail), I've decided to tackle #156 step-wise by reactivating each check separately (and fixing the reported issues at the same time). For example, see #169. /cc @cjyabraham

This PR mostly contains changes common for all checks i.e., docker removal, failing check on script errors. Do you want me to distribute it across multiple PRs along with respective check fixes, like you've done with #169 ?

[chalin]

Thanks for the offer. I suggest that we wait and see what happens with #169 first. I'm unsure about the other checks yet: I might bring in link checking next -- but that change will be based on how it's handled in some other CNCF projects.

[guidemetothemoon]

@Azanul @chalin we have recently had a larger refactoring in the repository to properly stabilize the workflow for content QA validation with tools like markdownlint, cspell and markdown-link-checker. As part of this refactoring all the validations have been moved away from Bash scripts into a single GitHub workflow where those validations now run as GitHub Actions. This will simplify the maintenance of the workflow and will make any potential errors more visible and transparent. You can find more information about refactoring in the original PR #269 and the documentation: https://github.com/cncf/tag-env-sustainability/blob/main/writing-style.md#pull-request-quality-checks

Due to this refactoring current PR is no longer applicable and we will therefore be closing it. Don't hesitate to reach out if anything is unclear or if you have any questions.

Thank you so much for your time and effort in the attempt to fix the original implementation, @Azanul - even though it wasn't merged due to a larger, more long-term optimization we nevertheless see your effort and appreciate it! Don't hesitate to check out any other open issues that we have in the repo if you would like to keep contributing 🙌