Update codebase #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added support for custom cache file name. Handy when you have configured two feeds pointing to the same packages folder. * added some air after commas in type parameter * added curlies, even on one liners * renamed misleading InitializeServerPackageStore method to InitializeServerPackageCache * Updated XML comment explaining the custom cache file name option * Throwing up on invalid cache file name. Added tests to prove it. * compacting test arrange code
… order to avoid erroneous cache invalidation in a multi-node deploymeny (#54) * Normalize nuget server path before comparing root paths. * Normalize nuget server path before comparing root paths. PR review changes.
* Use includeDelisted query parameter * Rename parameter to share the same paradigm with NuGetGallery. * Simplify tests
[ReleasePrep 2018-02-26]Merge dev into master
…te cache management (clear cache). (#59) * Appended allowRemoteCacheManagement key into web.config to allow remote cache management. * Revert "Appended allowRemoteCacheManagement key into web.config to allow remote cache management." This reverts commit daf5b2de1a218829253278b4b506f23bf48743b0. * Appended allowRemoteCacheManagement key into web.config to allow remote cache management. * Store web server settings in user file. * Appended allowRemoteCacheManagement key into web.config to allow remote cache management. * Revert "Appended allowRemoteCacheManagement key into web.config to allow remote cache management." This reverts commit daf5b2de1a218829253278b4b506f23bf48743b0. * Appended allowRemoteCacheManagement key into web.config to allow remote cache management. * Store web server settings in user file. * Update Web.config
Un-suppress file system events before releasing the lock. Add two configuration values which allow control of automatic cache rebuild. Add a concurrency integration test to ensure cache rebuilds don't occur from concurrent pushes. Address NuGet/NuGetGallery#6960.
This only affects the NuGetV2WebApiEnabler.UseNuGetV2WebApiFeed API. NuGet.Server still enables the legacy push route by default since it already assumes there is only one feed in the application. Address NuGet/NuGetGallery#7008
Replace V2 with V3 in nuget.config
Merge branch 'master' into dev
Merge branch 'dev' into master
* Added support for new -SkipDuplicate option in NuGet 5.1 * removed empty line in NuGetODataController.cs * DuplicatePackageException now extends Exception instead of InvalidOperationException * Fixed test ServerPackageRepositoryAddPackageRejectsDuplicatesWithSemVer2 by replacing InvalidOperationException with DuplicatePackageException * Added test PushDuplicatePackage
Merge branch 'dev' into master
See JamesNK/Newtonsoft.Json#2128 for more context. NuGet.Core always parses things as absolute URIs so it's not possible for strings only parsable as relative to it into the system. The weird case is something like `//fileserver/Framework/NuGet/server.png` which is parsable as both relative and absolute. Address NuGet/NuGetGallery#7414
Merge branch 'dev' into master
|
I'm 95%+ sure the csproj conflicts are a non-issue. My local git instance tells me that everything is up to date already even if I rebase on the choco_adds branch again. I think Github is probably just flipping out because of all the changes and merge conflicts in the choco_adds commits I had to sort out. |
vexx32
force-pushed
the
UpdateCodebase
branch
from
8b17bfe
to
0c3d6de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update this codebase to .NET Framework 4.8 and pull in newer changes from https://github.com/NuGet/NuGet.Server.
This was fairly smooth, the only thing we might want to consider is updating the Nuget.Core.dll that we have here. Not sure how that was built, but ideally we'd want to rebuild that for the newer framework version as well.