make context propagation robust to unavailability of root tracer #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DRV2SI
requested review from
a team,
aabmass,
hectorhdzg,
jeremydvoss and
lzchen
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
I have just signed the CLA. Please restart the respective verification step so the information gets checked again. |
DRV2SI
changed the title
DRV2SI
force-pushed
the
graceful-for-noop-tracer
branch
2 times, most recently
from
bfd6a20
to
f768bab
Compare
DRV2SI
force-pushed
the
graceful-for-noop-tracer
branch
from
f768bab
to
a099a02
Compare
|
this issue is a blocker in our project, any chance this could be reviewed and considered? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opencensus-ext-threadingcurrently breaks when there is no tracer to propagate upon thread creation.This pull request makes it robust to this situation. There is also an associated issue on GitHub.