-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance httpx tracing #1186
base: master
Are you sure you want to change the base?
Enhance httpx tracing #1186
Conversation
@macieyng update the changelog |
Thanks @lzchen for running the pipeline. I will fix it tomorrow. |
@lzchen ready for running the pipeline 🚀 |
@lzchen can you run the pipeline? Thanks! 🙏 |
That's not something that I touched and on my machine it fails even earlier, but that's because I'm running it locally on mac. @lzchen can I get your support with sorting this out? |
In httpx
Advanced Usage
docs there is a chapterRequest Instances
where they show alternative way of sending requests, where you can use once initialized client to send various of different requests to the same host.Current implementation of tracing doesn't cover that use case, because calling structure is different while function
Client.send
is actually what is common and it returnsResponse
object.In a nutshell:
so when I have something like this:
It's not traced.
The solution in this PR will cover both use cases - the standard one (requests-like) and the advanced usage.