change the way for logging integration #1084
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serjshevchenko
requested review from
aabmass,
hectorhdzg,
lzchen,
songy23 and
a team
as code owners
|
@aabmass @hectorhdzg @lzchen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix problem related to Note "Note that this only takes effect for loggers created after the integration."
Face with such issue when was trying to integrate opencensus-logging into uvicorn+FastAPI.
uvicorn starts application in new thread/process and creates uvicorn logger object in new thread/process before opencensus-logging-integration execution.
TraceLoggerjust overridesmakeRecord,logging.setLogRecordFactoryis a better approach because it has not drawback with time of logger object initialization.