This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Add StackdriverExporterOptions to StackdriverExporter::Register(). #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use this to configure RPC deadlines and whether to block until the exporter is connected. Also change Register() to return a grpc::Status.
|
This addresses #175 |
bogdandrutu
reviewed
Sep 5, 2018
| @@ -277,11 +280,23 @@ void Handler::Export( | |||
|
|
|||
| } // namespace | |||
|
|
|||
| void StackdriverExporter::Register(absl::string_view project_id) { | |||
| grpc::Status StackdriverExporter::Register( | |||
| absl::string_view project_id, const StackdriverExporterOptions& opts) { | |||
There was a problem hiding this comment.
project_id should be part of the options.
See for example java:
https://github.com/census-instrumentation/opencensus-java/blob/master/exporters/trace/stackdriver/src/main/java/io/opencensus/exporter/trace/stackdriver/StackdriverTraceConfiguration.java
|
Is this PR still needed? |
|
This work has stalled for now, but I intend to finish it. What's left to do is: wait for the exporter to connect and return a grpc::Status. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use this to configure RPC deadlines and whether to block until
the exporter is connected.
Also change Register() to return a grpc::Status.