fix(share)!: tendermint compatible get range result json marshall #3930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvolin
requested review from
renaynay,
Wondertan,
vgonkivs,
walldiss and
cristaloleg
as code owners
zvolin
force-pushed
the
fix/tendermint-compatible-get-range-result
branch
from
61f2ab2
to
363eb67
Compare
cristaloleg
added
kind:break!
cristaloleg
reviewed
Nov 12, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/api-breaks #3930 +/- ##
=====================================================
Coverage ? 45.10%
=====================================================
Files ? 307
Lines ? 21812
Branches ? 0
=====================================================
Hits ? 9839
Misses ? 10901
Partials ? 1072 ☔ View full report in Codecov by Sentry. |
Wondertan
reviewed
Nov 12, 2024
renaynay
approved these changes
Nov 13, 2024
walldiss
approved these changes
Nov 14, 2024
cristaloleg
approved these changes
Nov 14, 2024
zvolin
commented
Nov 14, 2024
zvolin
commented
Nov 14, 2024
fix misspelling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3918
Please note: this PR is BREAKING as GetRangeResult encoding has changed.