Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics/system): Enable resource consumption metrics. #3899

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

00x-dx
Copy link
Contributor

@00x-dx 00x-dx commented Oct 29, 2024

TLDR: Creating a drafted version of resource stats; it would be tracked along with the actual node metrics.

At a high level we are to introduce the following

  • disk stats (Aggregated)
  • cpu stats (Aggregated)
  • network stats (Aggregated)
  • memory stats

Feel free to provide your initial feedback.

-->

@github-actions github-actions bot added the external Issues created by non node team members label Oct 29, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 46.98163% with 202 lines in your changes missing coverage. Please review.

Project coverage is 45.07%. Comparing base (2469e7a) to head (b054e6a).
Report is 364 commits behind head on main.

Files with missing lines Patch % Lines
nodebuilder/node/system/memory.go 50.49% 41 Missing and 9 partials ⚠️
nodebuilder/node/system/cpu.go 40.74% 41 Missing and 7 partials ⚠️
nodebuilder/node/system/disk.go 45.56% 37 Missing and 6 partials ⚠️
nodebuilder/node/system/network.go 52.17% 27 Missing and 6 partials ⚠️
nodebuilder/node/system/metrics.go 52.27% 15 Missing and 6 partials ⚠️
nodebuilder/node/metrics.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3899      +/-   ##
==========================================
+ Coverage   44.83%   45.07%   +0.23%     
==========================================
  Files         265      315      +50     
  Lines       14620    22253    +7633     
==========================================
+ Hits         6555    10030    +3475     
- Misses       7313    11125    +3812     
- Partials      752     1098     +346     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external Issues created by non node team members
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants