Represent integer literals as IntLiteral not as i32.
#4532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sized integer types. In preparation for changing integer literals to be of `IntLiteral` type. Conversions from the integer literal type are only permitted when the value fits within the destination type. For now, if conversion cannot be checked because the source value is a symbolic constant, produce a symbolic constant representing the conversion rather than rejecting it.
Don't hold a Function& after it may have been invalidated by importing.
In `if cond then 1 else 2`, convert to `i32`.
|
Depends on #4526. |
jonmeow
reviewed
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an
IntLiteralappears as an operand of anifexpression, convert it toi32for now, so that we don't reject things likeif cond then 1 else 2due to having a non-constant value of typeIntLiteral.For tuple indexing expressions such as
(a, b).0, convert the index to typeIntLiteral, not to typei32. This isn't strictly necessary to do in this PR, but avoids the need to provide anIntLiteral->i32implicit conversion forno_preludetests using this syntax.