reverseproxy: add tls_server_cert_sha256 #6329
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Unfortunately there *are* some production setups requiring tls_insecure_skip_verify in reverse_proxy, like old devices with outdated firmware. In many such cases, the devices aren't supposed to regenerate or update their certificates. This patch adds tls_server_cert_sha256 directive for reverse_proxy, making MITM impossible even with tls_insecure_skip_verify.
akovalenko
force-pushed
the
master
branch
2 times, most recently
from
408709b
to
5fde819
Compare
mholt
reviewed
Nov 4, 2024
| // If non-empty, TLS compares the SHA-256 fingerprint of the | ||
| // server certificate to a fixed value, specified as | ||
| // hexadecimal string. | ||
| ServerCertSha256 string `json:"server_cert_sha256,omitempty"` |
There was a problem hiding this comment.
Suggested change
| ServerCertSha256 string `json:"server_cert_sha256,omitempty"` | |
| ServerCertSHA256 string `json:"server_cert_sha256,omitempty"` |
|
I have a similar use case where I reverse-proxy to a Podman container with a self-signed certificate that has a very long lifetime. |
|
@steffenbusch That's probably the preferred thing to do. @akovalenko does that work for you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately there are some production setups requiring tls_insecure_skip_verify in reverse_proxy, like old devices with outdated firmware. In many such cases, the devices aren't supposed to regenerate or update their certificates.
This patch adds tls_server_cert_sha256 directive for reverse_proxy, making MITM impossible even with tls_insecure_skip_verify.