-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added delete bot command. Minor bug fixes. #14
base: master
Are you sure you want to change the base?
Conversation
@@ -125,6 +136,10 @@ def post_endpoint(endpoint, body) | |||
call_endpoint("post", endpoint, body) | |||
end | |||
|
|||
def delete_endpoint(endpoint, body) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we'll ever need the body
here, feel free to remove it and pass in nil.
Thanks for the addition! Why the change to |
Ah I see, you're right it's supposed to be |
Please merge from master so that CI passes and I'll merge this. 👍 |
I have no trouble installing the ruby gem and I'm not sure what the problem is. |
I was testing on 3 Ruby versions and 2.0.0 was failing, so I removed it (I don't want to support it anyway). All you have to do is merge from master and that should make the CI happy :) |
Excuse my ignorance. But how do I merge from master? |
I see what I need to do. Apologies I thought I was up to date with the repository. |
Damn, seems like some dependency is failing to install |
I hadn't updated my ruby from 2.2.1. After updating to 2.2.2 I could no longer do a rake install. It looks like rspec needs to be updated. |
I seem to have reached the limit of my almost non existent knowledge of how ruby gems work. |
I think the problem is that travis can't run the tests because it can't install the gem xcskarel (v 0.16.2). I can't push the gem to rubygems.org because I don't have permission to do so. |
Ok, I finally got it working, there were Travis issues. Please merge from master, should make this green. |
No description provided.