-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored XcodeServerConfig
#32
Conversation
@@ -29,7 +29,7 @@ | |||
<BuildableReference | |||
BuildableIdentifier = "primary" | |||
BlueprintIdentifier = "3A7B48C41B2A5AC40077ABEA" | |||
BuildableName = "XcodeServerSDK - OS X Tests.xctest" | |||
BuildableName = "XcodeServerSDKTest.xctest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure you don't have additional schemes?
- Defined custom `ConfigurationErrors` - Addapted to new `JSONSerializable` throwable init - Silenced compiler warnings for `throwable` inits.
- Looks like bug on the parser in `Xcode 7 ß 1` is gone on `ß 2`
@czechboy0 just forced pushed the branch (I did a |
Awesome, thanks @esttorhe! |
Refactored `XcodeServerConfig`
Fix #28 (?)
As suggested by @czechboy0 here's a
PR
with the new «throwable» init approach using someguards
and a custom error enum.Done:
JSONSerializable
tothrow
oninit
XcodeServerConfig
ErrorType