Update security advisories with recently assigned CVE IDs #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xB10C
reviewed
Nov 18, 2024
| @@ -1,5 +1,5 @@ | |||
| --- | |||
| title: Disclosure of crash using malicious BIP72 URI | |||
| title: Disclosure of CVE-2024-52918 | |||
There was a problem hiding this comment.
I think it might be better to leave the title and just add the CVE number to the end
Suggested change
| title: Disclosure of CVE-2024-52918 | |
| title: Disclosure of crash using malicious BIP72 URI (CVE-2024-52918) |
There was a problem hiding this comment.
I agree but i chose to be consistent with previous advisories. If we want to change the existing format let's do it in another PR?
There was a problem hiding this comment.
I would also prefer if the titles continued to contain the gist of the vulnerability as the CVE ID provides zero context unless you know about the CVE in advance.
murchandamus
suggested changes
Nov 20, 2024
There was a problem hiding this comment.
This approach reduces the information content of the titles and I would consider it a disimprovement.
How about replacing the word "Disclosure" with the CVE ID? E.g.
-title: Disclosure of crash using malicious BIP72 URI
+title: CVE-2024-52918: Crash using malicious BIP72 URIOr what @0xB10C said.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the
inv-to-sendadvisory doesn't have one because there is a misunderstanding who claims it should beCVE-2023-33297. I explained it is an ID which was claimed by a troll on behalf of the project and i'm now awaiting their response. I don't think it should be a blocker to publish the other 13 IDs.