Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable wildcards in paths for config files #134

Merged
merged 7 commits into from
Jan 16, 2025

Conversation

bpinsard
Copy link
Contributor

@bpinsard bpinsard commented Jan 6, 2025

warning: I have zero knowledge in typescript
Attempts at fixing #133.

Enables usecases where one want to routinely run the BIDS-validator on datalad repo with only the git part checked-out while ignoring all warnings/errors that requires access to files with a generic efficient config file.

@bpinsard bpinsard marked this pull request as draft January 6, 2025 16:36
src/validators/filenameIdentify.test.ts Outdated Show resolved Hide resolved
src/validators/filenameIdentify.test.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I meant this...

src/validators/filenameIdentify.test.ts Show resolved Hide resolved
src/validators/filenameIdentify.test.ts Show resolved Hide resolved
@effigies
Copy link
Contributor

effigies commented Jan 6, 2025

Even though that worked, I think it's not testing exactly what we intended, as [ dir, base ] = tmpFile.split() would get the first two directories instead of the directory and the basename.

@bpinsard
Copy link
Contributor Author

bpinsard commented Jan 6, 2025

I see, so it modifies the tests logic, but it tests what it wanted to test originally: to error on a file that is not in the spec and not ignored by defaults ignores config, right?

@bpinsard bpinsard force-pushed the enh/config_wildcards branch from 1963166 to 9bbac82 Compare January 6, 2025 22:04
@bpinsard bpinsard marked this pull request as ready for review January 7, 2025 15:22
@rwblair
Copy link
Member

rwblair commented Jan 16, 2025

Looks like the wonky ignore typing may have been resolved in v7 of the library.

@rwblair rwblair merged commit 4e2978d into bids-standard:main Jan 16, 2025
17 checks passed
@rwblair
Copy link
Member

rwblair commented Jan 16, 2025

@bpinsard Thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants