-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable wildcards in paths for config files #134
Conversation
…ly created a file not starting with slash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I meant this...
Even though that worked, I think it's not testing exactly what we intended, as |
I see, so it modifies the tests logic, but it tests what it wanted to test originally: to error on a file that is not in the spec and not ignored by defaults ignores config, right? |
1963166
to
9bbac82
Compare
Looks like the wonky ignore typing may have been resolved in v7 of the library. |
@bpinsard Thank you for the PR! |
warning: I have zero knowledge in typescript
Attempts at fixing #133.
Enables usecases where one want to routinely run the BIDS-validator on datalad repo with only the git part checked-out while ignoring all warnings/errors that requires access to files with a generic efficient config file.