Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align behaviour of default table creation between sync and async table #5615

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zakerf
Copy link

@zakerf zakerf commented Sep 22, 2024

Motivation and Context

While migrating a project from the sync client to the async one I noticed failing tests in our project because of missing indices. We relied on createTable() to create the table in tests and after diving into it I saw that the secondary indices we have are not being created with the async variation.

Modifications

This adds the behaviour introduced in the sync DDB table to the async version as well. See commit ef2aa90 for original code

Testing

Haven't added any new code and the existing code already has proper unit tests

Screenshots (if appropriate)

Types of changes

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • [ x] I have read the CONTRIBUTING document
  • [ x] Local run of mvn install succeeds
  • [ x] My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • [ x] All new and existing tests passed
  • [ x] I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • [ x] I confirm that this pull request can be released under the Apache 2 license

This adds the behaviour introduced in the sync DDB table to the async version as well. See commit ef2aa90 for original code
@zakerf zakerf requested a review from a team as a code owner September 22, 2024 16:49
@zakerf
Copy link
Author

zakerf commented Oct 3, 2024

@L-Applin, I see you approved the original PR that this change is also based on, any chance you could look at this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant