-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): throw typed errors #33005
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter fails with the following errors:
❌ CLI code has changed. A maintainer must run the code through the testing pipeline (git fetch origin pull/33005/head && git push -f origin FETCH_HEAD:test-main-pipeline), then add the 'pr-linter/cli-integ-tested' label when the pipeline succeeds.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed, add Clarification Request
to a comment.
Enforce by enabling the respective eslint rule. Also adds this rule to the toolkit.
6f6aba5
to
9be5a2e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #33005 +/- ##
==========================================
+ Coverage 81.39% 81.44% +0.04%
==========================================
Files 225 225
Lines 13714 13750 +36
Branches 2411 2412 +1
==========================================
+ Hits 11162 11198 +36
Misses 2277 2277
Partials 275 275
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
Reason for this change
In #32548 we enabled typed errors for some places in the CLI.
However many places were missed and the eslint rule wasn't enabled to enforce it in future.
Description of changes
Enforce by enabling the respective eslint rule.
Also adds and implements the eslint rule in the toolkit.
This has little functional effect since all new errors are still
Error
s. The printed output of an error will slightly change.Describe any new or updated permissions being added
n/a
Description of how you validated changes
existing tests
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license