Skip to content

Commit

Permalink
Update to ACK runtime v0.40.0, code-generator v0.40.0 (#50)
Browse files Browse the repository at this point in the history
### Update to ACK runtime `v0.40.0`, code-generator `v0.40.0`

----------

* ACK code-generator `v0.40.0` [release notes](https://github.com/aws-controllers-k8s/code-generator/releases/tag/v0.40.0)
* ACK runtime `v0.40.0` [release notes](https://github.com/aws-controllers-k8s/runtime/releases/tag/v0.40.0)

----------

NOTE:
This PR increments the release version of service controller from `v1.0.0` to `v1.0.1`

Once this PR is merged, release `v1.0.1` will be automatically created for `acm-controller`

**Please close this PR, if you do not want the new patch release for `acm-controller`**

----------

#### stdout for `make build-controller`:

```
building ack-generate ... ok.
==== building acm-controller ====
Copying common custom resource definitions into acm
Building Kubernetes API objects for acm
Generating deepcopy code for acm
Generating custom resource definitions for acm
Building service controller for acm
Generating RBAC manifests for acm
Running gofmt against generated code for acm
Updating additional GitHub repository maintenance files
==== building acm-controller release artifacts ====
Building release artifacts for acm-v1.0.1
Generating common custom resource definitions
Generating custom resource definitions for acm
Generating RBAC manifests for acm
```

----------

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • Loading branch information
ack-bot authored Jan 14, 2025
1 parent 45ddcf1 commit f7b7627
Show file tree
Hide file tree
Showing 11 changed files with 43 additions and 21 deletions.
8 changes: 4 additions & 4 deletions apis/v1alpha1/ack-generate-metadata.yaml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
ack_generate_info:
build_date: "2024-11-06T19:23:27Z"
build_hash: 36c2d234498c2bc4f60773ab8df632af4067f43b
go_version: go1.22.4
version: v0.39.1
build_date: "2024-12-09T17:31:17Z"
build_hash: 631aeb190e332addb8379672df6367a0875dce88
go_version: go1.23.3
version: v0.40.0
api_directory_checksum: b055cc57ac2cc8b07e374803c280b65d1a72f3bf
api_version: v1alpha1
aws_sdk_go_version: v1.49.0
Expand Down
4 changes: 4 additions & 0 deletions config/controller/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ spec:
- "$(LEADER_ELECTION_NAMESPACE)"
- --reconcile-default-max-concurrent-syncs
- "$(RECONCILE_DEFAULT_MAX_CONCURRENT_SYNCS)"
- --feature-gates
- "$(FEATURE_GATES)"
image: controller:latest
name: controller
ports:
Expand Down Expand Up @@ -76,6 +78,8 @@ spec:
value: "ack-system"
- name: "RECONCILE_DEFAULT_MAX_CONCURRENT_SYNCS"
value: "1"
- name: "FEATURE_GATES"
value: ""
securityContext:
allowPrivilegeEscalation: false
privileged: false
Expand Down
2 changes: 1 addition & 1 deletion config/controller/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ kind: Kustomization
images:
- name: controller
newName: public.ecr.aws/aws-controllers-k8s/acm-controller
newTag: 1.0.0
newTag: 1.0.1
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ toolchain go1.22.5

require (
github.com/aws-controllers-k8s/acmpca-controller v0.0.17
github.com/aws-controllers-k8s/runtime v0.39.0
github.com/aws-controllers-k8s/runtime v0.40.0
github.com/aws/aws-sdk-go v1.49.6
github.com/go-logr/logr v1.4.2
github.com/spf13/pflag v1.0.5
Expand Down
4 changes: 2 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
github.com/aws-controllers-k8s/acmpca-controller v0.0.17 h1:i1YyvDui8LNbwLwkXsr+jVoyCP49+ie4CZq1RRq7Tz0=
github.com/aws-controllers-k8s/acmpca-controller v0.0.17/go.mod h1:BaLyCLbP5GibqqT4qANmDxAX3CYHatA+dQNFe5fOk+M=
github.com/aws-controllers-k8s/runtime v0.39.0 h1:IgOXluSzvb4UcDr9eU7SPw5MJnL7kt5R6DuF5Qu9zVQ=
github.com/aws-controllers-k8s/runtime v0.39.0/go.mod h1:G07g26y1cxyZO6Ngp+LwXf03CqFyLNL7os4Py4IdyGY=
github.com/aws-controllers-k8s/runtime v0.40.0 h1:FplFYgzCIbQsPafarP3dy/4bG1uGR8G1OLYOWO4a7Lc=
github.com/aws-controllers-k8s/runtime v0.40.0/go.mod h1:G07g26y1cxyZO6Ngp+LwXf03CqFyLNL7os4Py4IdyGY=
github.com/aws/aws-sdk-go v1.49.6 h1:yNldzF5kzLBRvKlKz1S0bkvc2+04R1kt13KfBWQBfFA=
github.com/aws/aws-sdk-go v1.49.6/go.mod h1:LF8svs817+Nz+DmiMQKTO3ubZ/6IaTpq3TjupRn3Eqk=
github.com/beorn7/perks v1.0.1 h1:VlbKKnNfV8bJzeqoa4cOKqO6bYr3WgKZxO8Z16+hsOM=
Expand Down
4 changes: 2 additions & 2 deletions helm/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
apiVersion: v1
name: acm-chart
description: A Helm chart for the ACK service controller for AWS Certificate Manager (ACM)
version: 1.0.0
appVersion: 1.0.0
version: 1.0.1
appVersion: 1.0.1
home: https://github.com/aws-controllers-k8s/acm-controller
icon: https://raw.githubusercontent.com/aws/eks-charts/master/docs/logo/aws.png
sources:
Expand Down
2 changes: 1 addition & 1 deletion helm/templates/NOTES.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{{ .Chart.Name }} has been installed.
This chart deploys "public.ecr.aws/aws-controllers-k8s/acm-controller:1.0.0".
This chart deploys "public.ecr.aws/aws-controllers-k8s/acm-controller:1.0.1".

Check its status by running:
kubectl --namespace {{ .Release.Namespace }} get pods -l "app.kubernetes.io/instance={{ .Release.Name }}"
Expand Down
6 changes: 3 additions & 3 deletions helm/templates/caches-role-binding.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ roleRef:
name: ack-namespaces-cache-acm-controller
subjects:
- kind: ServiceAccount
name: ack-acm-controller
name: {{ include "ack-acm-controller.service-account.name" . }}
namespace: {{ .Release.Namespace }}
---
apiVersion: rbac.authorization.k8s.io/v1
Expand All @@ -22,5 +22,5 @@ roleRef:
name: ack-configmaps-cache-acm-controller
subjects:
- kind: ServiceAccount
name: ack-acm-controller
namespace: {{ .Release.Namespace }}
name: {{ include "ack-acm-controller.service-account.name" . }}
namespace: {{ .Release.Namespace }}
6 changes: 4 additions & 2 deletions helm/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

image:
repository: public.ecr.aws/aws-controllers-k8s/acm-controller
tag: 1.0.0
tag: 1.0.1
pullPolicy: IfNotPresent
pullSecrets: []

Expand Down Expand Up @@ -163,4 +163,6 @@ featureGates:
# Enables the Team level granularity for CARM. See https://github.com/aws-controllers-k8s/community/issues/2031
TeamLevelCARM: false
# Enable ReadOnlyResources feature/annotation.
ReadOnlyResources: false
ReadOnlyResources: false
# Enable ResourceAdoption feature/annotation.
ResourceAdoption: false
10 changes: 5 additions & 5 deletions pkg/resource/certificate/descriptor.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 16 additions & 0 deletions pkg/resource/certificate/resource.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit f7b7627

Please sign in to comment.