Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dummy_diag_publisher): update param setting #9946

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

TetsuKawa
Copy link
Contributor

@TetsuKawa TetsuKawa commented Jan 16, 2025

Description

This PR adds param set function as described in the README and refactor slightly.

  • add param_callback_handle_ and onSetParams.
  • delete unnecessary dependency packages.
  • add const.

Related links

Private Links:

How was this PR tested?

  1. $ ros2 launch dummy_diag_publisher dummy_diag_publisher.launch.xml
  2. $ ros2 param set /dummy_diag_publisher dummy_diag_empty.is_active true or false
  3. $ ros2 param set /dummy_diag_publisher dummy_diag_empty.status "Error", Warn, OK
  4. confirm by ros2 topic echo /diagnostics or rqt_runtime_monitor
Screencast.from.2025.01.18.11.49.20.webm

(in addition)

  1. $ ros2 launch autoware_launch planning_simulator.launch.xml map_path:=$HOME/autoware_map/sample-map-planning vehicle_model:=sample_vehicle sensor_model:=sample_sensor_kit
  2. $ ros2 param set /dummy_diag_publisher "topic_state_monitor_pointcloud_map: map_topic_status".is_active true or false
  3. $ ros2 param set /dummy_diag_publisher "topic_state_monitor_pointcloud_map: map_topic_status".status "Error", Warn or OK

Dummy "topic_state_monitor_pointcloud_map: map_topic_status" is defined in autoware_launch/config/system/diagnostics/dummy_diag_publisher.param.yaml.

/**:
ros__parameters:
required_diags:
# map
## /autoware/map/topic_rate_check/pointcloud_map
"topic_state_monitor_pointcloud_map: map_topic_status": default

Screencast.from.2025.01.18.14.13.53.webm

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label Jan 16, 2025
Copy link

github-actions bot commented Jan 16, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@TetsuKawa TetsuKawa added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed component:system System design and integration. (auto-assigned) labels Jan 16, 2025
@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label Jan 16, 2025
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.

Project coverage is 29.12%. Comparing base (67ab350) to head (e141641).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
...y_diag_publisher/src/dummy_diag_publisher_core.cpp 0.00% 29 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9946      +/-   ##
==========================================
- Coverage   29.13%   29.12%   -0.01%     
==========================================
  Files        1425     1425              
  Lines      107853   107821      -32     
  Branches    42251    42235      -16     
==========================================
- Hits        31419    31400      -19     
+ Misses      73391    73380      -11     
+ Partials     3043     3041       -2     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 29.13% <ø> (-0.01%) ⬇️ Carriedforward from dd632fc

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TetsuKawa TetsuKawa marked this pull request as ready for review January 18, 2025 03:12
@TetsuKawa TetsuKawa requested a review from ito-san as a code owner January 18, 2025 03:12
@ito-san
Copy link
Contributor

ito-san commented Jan 18, 2025

@TetsuKawa Did you confirm that the issues identified in this PR have been resolved?
tier4#1272

@TetsuKawa
Copy link
Contributor Author

TetsuKawa commented Jan 18, 2025

@ito-san

Did you confirm that the issues identified in this PR have been resolved?

Yes.
I confirmed that parameters can be set even if they are written in the form param: defalt.
I actually ran psim and set the parameters.
Please see the video in the updated comment section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:clang-tidy-pr-review tag:require-cuda-build-and-test
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

2 participants