-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dummy_diag_publisher): update param setting #9946
base: main
Are you sure you want to change the base?
feat(dummy_diag_publisher): update param setting #9946
Conversation
Signed-off-by: TetsuKawa <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: TetsuKawa <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9946 +/- ##
==========================================
- Coverage 29.13% 29.12% -0.01%
==========================================
Files 1425 1425
Lines 107853 107821 -32
Branches 42251 42235 -16
==========================================
- Hits 31419 31400 -19
+ Misses 73391 73380 -11
+ Partials 3043 3041 -2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@TetsuKawa Did you confirm that the issues identified in this PR have been resolved? |
Yes. |
Description
This PR adds param set function as described in the README and refactor slightly.
param_callback_handle_
andonSetParams
.const
.Related links
Private Links:
How was this PR tested?
$ ros2 launch dummy_diag_publisher dummy_diag_publisher.launch.xml
$ ros2 param set /dummy_diag_publisher dummy_diag_empty.is_active true
orfalse
$ ros2 param set /dummy_diag_publisher dummy_diag_empty.status "Error"
,Warn
,OK
ros2 topic echo /diagnostics
or rqt_runtime_monitorScreencast.from.2025.01.18.11.49.20.webm
(in addition)
$ ros2 launch autoware_launch planning_simulator.launch.xml map_path:=$HOME/autoware_map/sample-map-planning vehicle_model:=sample_vehicle sensor_model:=sample_sensor_kit
$ ros2 param set /dummy_diag_publisher "topic_state_monitor_pointcloud_map: map_topic_status".is_active true
orfalse
$ ros2 param set /dummy_diag_publisher "topic_state_monitor_pointcloud_map: map_topic_status".status "Error"
,Warn
orOK
Dummy "topic_state_monitor_pointcloud_map: map_topic_status" is defined in
autoware_launch/config/system/diagnostics/dummy_diag_publisher.param.yaml
.Screencast.from.2025.01.18.14.13.53.webm
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.