Bump github.com/JohannesKaufmann/html-to-markdown from 1.4.0 to 1.6.0 in /ruledocsgen #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #735 +/- ##
==========================================
+ Coverage 90.05% 90.20% +0.14%
==========================================
Files 44 43 -1
Lines 6800 6638 -162
==========================================
- Hits 6124 5988 -136
+ Misses 553 536 -17
+ Partials 123 114 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Bumps [github.com/JohannesKaufmann/html-to-markdown](https://github.com/JohannesKaufmann/html-to-markdown) from 1.4.0 to 1.6.0. - [Release notes](https://github.com/JohannesKaufmann/html-to-markdown/releases) - [Commits](JohannesKaufmann/html-to-markdown@v1.4.0...v1.6.0) --- updated-dependencies: - dependency-name: github.com/JohannesKaufmann/html-to-markdown dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/go_modules/ruledocsgen/github.com/JohannesKaufmann/html-to-markdown-1.6.0
branch
from
7e5a3d4
to
ada6779
Compare
Go 1.17 has a different handling of dependencies. By default, it emulates the old behavior for compatibility with older Go versions. The Dependabot PRs are produced in this manner. This project now uses Go 1.17 exclusively, as is indicated by the `go` directive and by the contributor guide. There is no need to provide compatibility with unsupported Go versions, so we use the `-compat=1.17` flag in the `go mod tidy` command, as is done here.
per1234
reviewed
Jun 5, 2024
There was a problem hiding this comment.
This causes go build to fail for the github.com/arduino/arduino-lint/ruledocsgen module, as shown in the failure of the "Check Website" workflow:
https://github.com/arduino/arduino-lint/actions/runs/9379124006/job/25823527189?pr=735#step:7:73
Error: ../../../../go/pkg/mod/golang.org/x/[email protected]/http2/transport.go:1109:13: tc.NetConn undefined (type *tls.Conn has no field or method NetConn)
The solution will be to update the version of Go used by the project:
$ task go:rule-docs:build
task: [go:rule-docs:build] go build
# golang.org/x/net/http2
C:\Users\per\go\pkg\mod\golang.org\x\[email protected]\http2\transport.go:1109:13: tc.NetConn undefined (type *tls.Conn has no field or method NetConn)
note: module requires Go 1.18
task: Failed to run task "go:rule-docs:build": exit status 2
Since resources are not available to take on that significant task at this time, this PR must be put on hold.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps github.com/JohannesKaufmann/html-to-markdown from 1.4.0 to 1.6.0.
Release notes
Sourced from github.com/JohannesKaufmann/html-to-markdown's releases.
Commits
aec0c4aupdate dependenciese92a7a3Add support for youtube-nocookie.com domain in YoutubeEmbed plugin (#99)2ec2259Bump golang.org/x/net from 0.18.0 to 0.19.0 (#83)155a78bchange vimeo & youtube embed plugins & README plugin listfc090b2feat: configure start of ol lista5828fdBump golang.org/x/net from 0.14.0 to 0.18.0 (#82)fab894eBump github.com/yuin/goldmark from 1.5.5 to 1.6.0 (#81)bcbfd0dBump golang.org/x/net from 0.9.0 to 0.14.0 (#74)afdc7dfBump github.com/yuin/goldmark from 1.5.4 to 1.5.5 (#73)2273319updated logoYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)