ZOOKEEPER-4858: Remove the lock contention between snapshotting and the sync operation #2185
+13
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eolivelli can I get a review for this? Thanks |
anmolnar
requested changes
Sep 12, 2024
…he sync operation Author: Li Wang <[email protected]>
li4wang
force-pushed
the
ZOOKEEPER-4858
branch
from
ccdf4e5
to
03fe4ea
Compare
|
Thanks for reviewing it, @anmolnar. Yes, we would still want exclusive locking between snapshot and restore to make sure data tree is not replaced by restoring operation while snapshotting is in progress. |
|
added a specific lock just for snapshot and restore operations. @anmolnar would you mind taking a look at it. Thanks. |
|
@anmolnar I've addressed your comment. Can you take a quick look at it? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Author: Li Wang [email protected]