Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install to remind new mac user account on which shell profile to modify #312

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Shanfang
Copy link

Add tips for new mac user account (created in macOS Catalina or later) when adding new directory toPATH environment variable, .zprofile should be used instead of .bash_profile as macOS automatically sourced zsh shell.

Add tips for new mac user account (created in macOS Catalina or later) when adding new directory to`PATH` environment variable.
@apache apache deleted a comment from Tayevans09 Sep 5, 2022
@@ -70,6 +70,7 @@ The same dialog can be used to set `JAVA_HOME` to the location of your JDK, e.g.

Unix-based Operating System (Linux, Solaris and Mac OS X) Tips
-----
Apple sets the zsh shell as the default for any new user account that is created in macOS Catalina(10.15.7) or later. Thus, `.zprofile` is the startup file when you open up a terminal. You would need to modify `PATH` environment variable in `.zprofile` instead of `.bash_profile`. But if you upgraded your macOS from an earlier version, you can still add environment variable to `.bash_profile`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is worth mentioning but there are more than just two shells. Can this be rewritten in a more shell independent fashion?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd even drop this because it may fall out of date or is too system and shell specific. If someone isn't able to set variabled permanently, change job.

Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am rather rejecting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants