-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hotfix] Update copyright NOTICE year to 2025 #25916
base: master
Are you sure you want to change the base?
Conversation
Hi @rmetzger ,Now that it's 2025, maybe we should update it.Please take a look in your spare time,thank you very much! |
Copyright (c) 2015 Dmitry Ivanov | ||
|
||
Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can we remove this as it seems to be removing and adding the same content. Or is there some intended change here?
OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR | ||
Copyright (c) Microsoft Corporation. | ||
|
||
Permission to use, copy, modify, and/or distribute this software for any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can we remove this as it seems to be removing and adding the same content. Or is there some intended change here?
@davidradl thanks for your review,I updated it. |
@@ -1053,13 +1053,10 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. | |||
--- | |||
[email protected] | |||
--- | |||
The MIT License (MIT) | |||
Copyright (c) 2015 Dmitry Ivanov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove a Copyright like this? copyright lines are normally something that would not be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course we can. I'm sorry, I wasn't paying attention. It's updated now, please take a look at it sometime, thanks!
Reviewed by Chi on 09/01/2025 Go back to the submitter with review comments. |
What is the purpose of the change
Update copyright NOTICE year to 2025.
Brief change log
(for example:)
Verifying this change
Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation