Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opt](jsonb) add ut for the jsonb parser #47181

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

csun5285
Copy link
Contributor

@csun5285 csun5285 commented Jan 17, 2025

What problem does this PR solve?

Problem Summary:

Add unit tests for the jsonb parser

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@csun5285
Copy link
Contributor Author

run buildall

@csun5285 csun5285 changed the title [opt](jsonb) add ut case for jsonb parser [opt](jsonb) add ut for jsonb parser Jan 17, 2025
@csun5285 csun5285 changed the title [opt](jsonb) add ut for jsonb parser [opt](jsonb) add ut for the jsonb parser Jan 17, 2025
eldenmoon
eldenmoon previously approved these changes Jan 17, 2025
Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 17, 2025
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@csun5285
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jan 17, 2025
@doris-robot
Copy link

TPC-H: Total hot run time: 32262 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4efd294f6260da1e352996bf1199597408678e4e, data reload: false

------ Round 1 ----------------------------------
q1	15489	5519	5366	5366
q2	1869	313	178	178
q3	4409	1260	718	718
q4	9450	953	512	512
q5	7445	2419	2182	2182
q6	201	167	132	132
q7	912	766	599	599
q8	2324	1395	1217	1217
q9	5095	4890	4847	4847
q10	2256	2371	1899	1899
q11	407	273	263	263
q12	314	357	219	219
q13	3351	3702	3116	3116
q14	234	224	212	212
q15	521	480	467	467
q16	633	628	574	574
q17	554	867	325	325
q18	6984	6539	6421	6421
q19	578	947	550	550
q20	314	319	207	207
q21	2824	2257	1950	1950
q22	360	342	308	308
Total cold run time: 66524 ms
Total hot run time: 32262 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5406	5447	5462	5447
q2	237	328	244	244
q3	2283	2649	2346	2346
q4	1372	1830	1388	1388
q5	4319	4748	4643	4643
q6	166	160	122	122
q7	1989	1868	1730	1730
q8	2506	2722	2621	2621
q9	6968	6889	6879	6879
q10	2848	3177	2668	2668
q11	560	502	478	478
q12	661	734	586	586
q13	3253	3703	3144	3144
q14	263	281	272	272
q15	502	466	462	462
q16	634	660	656	656
q17	1190	1693	1203	1203
q18	7197	7317	7145	7145
q19	759	988	1112	988
q20	1979	1966	1819	1819
q21	5394	5200	4895	4895
q22	635	581	548	548
Total cold run time: 51121 ms
Total hot run time: 50284 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 187844 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4efd294f6260da1e352996bf1199597408678e4e, data reload: false

query1	977	381	372	372
query2	6520	2042	2060	2042
query3	6795	215	210	210
query4	34020	23601	23296	23296
query5	5120	608	464	464
query6	296	205	195	195
query7	4623	488	302	302
query8	301	243	241	241
query9	9457	2576	2585	2576
query10	501	315	253	253
query11	17994	15252	14954	14954
query12	164	111	106	106
query13	1656	533	410	410
query14	12124	6399	7345	6399
query15	251	195	189	189
query16	8558	659	467	467
query17	1588	716	555	555
query18	2147	399	294	294
query19	207	177	153	153
query20	114	107	128	107
query21	208	134	102	102
query22	4388	4392	4277	4277
query23	33965	32966	33241	32966
query24	6164	2248	2300	2248
query25	505	460	390	390
query26	1197	272	151	151
query27	2033	477	329	329
query28	5137	2423	2392	2392
query29	749	545	422	422
query30	235	186	159	159
query31	947	878	771	771
query32	100	60	61	60
query33	499	364	300	300
query34	755	868	493	493
query35	784	808	754	754
query36	1009	1015	966	966
query37	117	95	85	85
query38	4121	4089	4157	4089
query39	1439	1411	1399	1399
query40	208	113	102	102
query41	52	51	51	51
query42	141	108	105	105
query43	494	527	493	493
query44	1257	804	799	799
query45	175	171	163	163
query46	859	1041	633	633
query47	1819	1862	1765	1765
query48	364	393	343	343
query49	782	478	402	402
query50	630	670	393	393
query51	6916	6746	6896	6746
query52	101	98	89	89
query53	220	244	191	191
query54	479	514	412	412
query55	81	80	80	80
query56	255	274	238	238
query57	1172	1166	1105	1105
query58	249	238	264	238
query59	3142	3087	2928	2928
query60	289	268	251	251
query61	123	119	137	119
query62	762	708	659	659
query63	219	191	189	189
query64	4276	1014	665	665
query65	3280	3138	3149	3138
query66	1085	430	323	323
query67	15896	15673	15674	15673
query68	5171	819	532	532
query69	455	298	267	267
query70	1182	1150	1119	1119
query71	410	286	258	258
query72	5860	3847	3827	3827
query73	637	743	351	351
query74	10591	9035	9039	9035
query75	3194	3139	2694	2694
query76	3103	1172	782	782
query77	488	357	275	275
query78	9972	9950	9529	9529
query79	2991	793	593	593
query80	721	574	447	447
query81	513	284	235	235
query82	359	161	124	124
query83	178	175	152	152
query84	244	94	77	77
query85	756	433	311	311
query86	371	332	298	298
query87	4440	4557	4424	4424
query88	4868	2146	2108	2108
query89	398	330	291	291
query90	1971	189	187	187
query91	133	141	107	107
query92	77	59	57	57
query93	2761	858	527	527
query94	715	414	303	303
query95	341	266	260	260
query96	487	612	281	281
query97	2754	2837	2729	2729
query98	221	196	209	196
query99	1286	1386	1237	1237
Total cold run time: 290739 ms
Total hot run time: 187844 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.96 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4efd294f6260da1e352996bf1199597408678e4e, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.03	0.04
query3	0.24	0.06	0.07
query4	1.61	0.11	0.10
query5	0.42	0.41	0.41
query6	1.18	0.66	0.65
query7	0.02	0.02	0.01
query8	0.04	0.03	0.04
query9	0.59	0.51	0.50
query10	0.56	0.57	0.55
query11	0.15	0.10	0.10
query12	0.14	0.12	0.12
query13	0.60	0.60	0.60
query14	2.73	2.73	2.71
query15	0.90	0.82	0.83
query16	0.39	0.37	0.38
query17	0.99	0.98	1.04
query18	0.22	0.21	0.21
query19	1.87	1.90	2.02
query20	0.01	0.01	0.01
query21	15.35	0.91	0.61
query22	0.76	0.75	0.69
query23	15.39	1.41	0.58
query24	2.81	1.10	1.81
query25	0.24	0.16	0.08
query26	0.25	0.15	0.13
query27	0.06	0.07	0.06
query28	14.23	0.96	0.42
query29	12.59	3.99	3.34
query30	0.26	0.09	0.06
query31	2.84	0.57	0.39
query32	3.22	0.54	0.45
query33	3.04	3.05	3.00
query34	16.67	5.20	4.52
query35	4.61	4.59	4.54
query36	0.63	0.49	0.49
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.03
query40	0.17	0.14	0.13
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.21 s
Total hot run time: 30.96 s

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 41.54% (10830/26070)
Line Coverage: 31.96% (91624/286703)
Region Coverage: 31.11% (46962/150931)
Branch Coverage: 27.24% (23825/87468)
Coverage Report: http://coverage.selectdb-in.cc/coverage/4efd294f6260da1e352996bf1199597408678e4e_4efd294f6260da1e352996bf1199597408678e4e/report/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants