-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log container to STDOUT + List and Stop running services #16851
base: main
Are you sure you want to change the base?
Conversation
1e06f65
to
21a1bae
Compare
Maybe use
Show just some basic information
Should more details Then its the same as for camel run |
printer().println("Shutting down service " + serviceToStop + " (PID: " + pid + ")"); | ||
FileUtil.deleteFile(pidFile); | ||
|
||
ProcessHandle.of(Long.valueOf(pid)).ifPresent(ph -> ph.destroyForcibly()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this give test container time to stop the service cleanly, as if you destroy the pid by force then would that not be something like kill -9 ?
@@ -151,6 +151,12 @@ | |||
<artifactId>plexus-xml</artifactId> | |||
</dependency> | |||
|
|||
<dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah we need to not have this dependency.
You can dynamic download this JAR via that camel maven thing, and we can maybe try set its scope = provided so camel run will not use it normally. And then you can still compile and use its API just that you have downloaded the JAR first.
Otherwise we can also move the command to its own camel jbnag plugin then the dependency can be there (just k8s has kube client JAR etc). But then users need to install this plugin first before they can use it.
camel infra stop minio
that will delete the file and kill the process (@davsclaus I used a slightly different approach compared to StopProcess).I'd remove the log
Press any key to stop the execution
since infra stop is implemented, wdyt?