Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wait_for_steps_completion option to EmrCreateJobFlowOperator. #44055

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adrian-adikteev
Copy link

@adrian-adikteev adrian-adikteev commented Nov 15, 2024


Currently, when using wait_for_complition=True it will trigger the node to only wait until the cluster is successfully launched.
I added the option wait_for_steps_completion so that it will also await the cluster to be terminated successfully.

This is useful because it will eliminate the need to have an extra node in your DAG.

Copy link

boring-cyborg bot commented Nov 15, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@adrian-adikteev adrian-adikteev force-pushed the emr-job-flow-operator-add-wait-steps-completion branch from 020522f to 3329599 Compare November 15, 2024 12:35
Copy link
Contributor

@vincbeck vincbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you cover this new use case in a unit test?

Comment on lines 672 to +673
wait_for_completion: bool = False,
wait_for_steps_completion: bool = False,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think both wait_for_completion and wait_for_steps_completion can be very confusing.
If we are to support the new functionality I suggest to introduce a new parameter wait_policy which will accept value of wait_for_steps_completion, wait_for_steps_completed_and_machine_terminated similar to what we did with Kubernetes in #30718 when we had more than just a bool option for delete pod.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:amazon-aws AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants