Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improves update metrics #5064

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

improves update metrics #5064

wants to merge 1 commit into from
+70 −18

Conversation

keith-turner
Copy link
Contributor

Made the following updates to update metrics

  • Added metrics for conditional mutation check and lock
  • Fixed counting for update metrics that documented per mutation but were not actually counting mutations
  • Fixed ingest metric that stated it was counting mutations but was actually counting entries.

@keith-turner
improves update metrics
f9616c1 
Made the following updates to update metrics

 * Added metrics for conditional mutation check and lock
 * Fixed counting for update metrics that documented per mutation but
   were not actually counting mutations
 * Fixed ingest metric that stated it was counting mutations but was
   actually counting entries.
@keith-turner keith-turner added this to the 4.0.0 milestone Nov 15, 2024
cshannon
cshannon approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@cshannon cshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the new metrics look useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cshannon cshannon cshannon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@keith-turner @cshannon