Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: building with notify only #658

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

dibbel26
Copy link
Contributor

@dibbel26 dibbel26 commented Jan 6, 2025

While (#562) implemented conditional compilation for notify without streaming the used function seems to be deprecated with &track out of scope. Replacing it with Self::notify_new_track(&track, &path)?; fixes the issue.

While (aome510#562) implemented conditional compilation for notify without
streaming the used function seems to be deprecated with &track out of
scope. Replacing it with Self::notify_new_track(&track, &path)?; fixes
the issue.
Copy link
Owner

@aome510 aome510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@aome510 aome510 merged commit 2d2a16a into aome510:master Jan 9, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants