Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pull in openssl #632

Closed
wants to merge 10 commits into from
Closed

Don't pull in openssl #632

wants to merge 10 commits into from

Conversation

cycle-five
Copy link
Contributor

The feature added to reqwest I don't believe is needed and it unnecessarily pulls in openssl into the project.

@aome510
Copy link
Owner

aome510 commented Dec 10, 2024

See #622

@cycle-five
Copy link
Contributor Author

Could this have some relevance? https://stackoverflow.com/questions/74652786/how-to-set-apln-protocols-before-tls-handshake-with-openssl-in-rust
I really would prefer to use both your library, and to not pull openssl into my project, so I'm willing to take on this issue myself but any help on where the issue can be fixed within the rustls feature branch would be appreciated.

@aome510
Copy link
Owner

aome510 commented Dec 14, 2024

@cycle-five with #635 landed, the use lyric-finder in the main project is no longer needed. Feel free to fork the implementation yourself. It's pretty short.

In the meantime, I'll close this PR for now. Lmk if you have any other questions.

@aome510 aome510 closed this Dec 14, 2024
@cycle-five cycle-five mentioned this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants