Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add floating ip feature #39

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ggggut
Copy link
Collaborator

@ggggut ggggut commented Nov 15, 2021

Hi,

I've added floating_ip as an usable option.
It may be useful :)

Please let me know if your are fine with it like this.

BR.

@ggggut
Copy link
Collaborator Author

ggggut commented Nov 29, 2021

Hi @decentral1se,
you had any chance yet to take a look at this? We think it could be a nice addition to the module.

Thank you!
Best Regards from Hetzner!

@ssbarnea
Copy link
Member

ssbarnea commented Dec 2, 2021

@ggggut My impression is that this plugin is not actively maintained and few days ago I had to remove the digitalocean one from the official list.

If you can help maintaining it, I will add you to the project and avoid taking a measure that may not be popular.

@ggggut
Copy link
Collaborator Author

ggggut commented Dec 6, 2021

@ssbarnea sure you can add me to the project.

@ssbarnea
Copy link
Member

@ggggut I sent you and invite, check https://github.com/ansible-community/molecule-hetznercloud/invitations

It would also be a good idea to ping me on matrix so I can help you with maintenance questions.

@ssbarnea ssbarnea added the enhancement This issue/PR relates to a feature request. label Dec 29, 2021
@ssbarnea ssbarnea closed this Dec 29, 2021
@ssbarnea ssbarnea reopened this Dec 29, 2021
@ssbarnea
Copy link
Member

@ggggut I activated pre-commit as a start. Fix it so we can merge this and we can work to add GHA after.

@ggggut
Copy link
Collaborator Author

ggggut commented Feb 8, 2022

Hi @ssbarnea, sorry i was busy in the last weeks. Can I merge this? packaging and uploading to pypi should work automatically, right?

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

This PR has been marked as stale because it has not had recent activity. The bot will close the PR if no further action occurs.

@github-actions github-actions bot added the stale Not updated in long time, will be closed soon. label Oct 4, 2023
@jooola jooola removed enhancement This issue/PR relates to a feature request. stale Not updated in long time, will be closed soon. labels Oct 4, 2023
@jooola jooola self-assigned this Oct 4, 2023
@jooola jooola marked this pull request as draft October 4, 2023 13:41
Copy link

github-actions bot commented Jan 3, 2024

This PR has been marked as stale because it has not had recent activity. The bot will close the PR if no further action occurs.

@github-actions github-actions bot added the stale Not updated in long time, will be closed soon. label Jan 3, 2024
@jooola jooola added pinned and removed stale Not updated in long time, will be closed soon. labels Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants