Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vitest-angular): set correct type in package.json based on output format #1438

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

brandonroberts
Copy link
Member

PR Checklist

Closes #1436
Closes #1437

What is the new behavior?

  • Sets the type is set to commonjs for the vitest-angular package to be fully compatible with Angular builders and native Vitest.
  • Fixes console warning about sourcemaps

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit c81aed8
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/672e2230fa18080008575260
😎 Deploy Preview https://deploy-preview-1438--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit c81aed8
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/672e223053e5100008fdaf48
😎 Deploy Preview https://deploy-preview-1438--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit c81aed8
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/672e223046196500083ff096
😎 Deploy Preview https://deploy-preview-1438--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for analog-ng-app ready!

Name Link
🔨 Latest commit c81aed8
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/672e223053e5100008fdaf4a
😎 Deploy Preview https://deploy-preview-1438--analog-ng-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts brandonroberts merged commit 1f078ff into beta Nov 8, 2024
24 checks passed
@brandonroberts brandonroberts deleted the fix-vitest-type branch November 8, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant